[patch] dbus_message_iter_get_args_valist does not skip last argument

Timo Teräs ext-timo.teras at nokia.com
Thu May 6 00:04:13 EST 2004


I found out that dbus_message_iter_get_args_valist() does not skip the last 
argument in iterator. The error is in line 2385 of dbus-message.c:
if (spec_type != 0 && !dbus_message_iter_next (iter))

This effectively prevents dbus_message_iter_next() being called if the last 
argument was being parsed, which is propably not the intended action. 
Changing the comparision order does the trick. Patch attached.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: dbus_message_iter_get_args_valist_fix.diff
Type: text/x-patch
Size: 675 bytes
Desc: not available
Url : http://freedesktop.org/pipermail/dbus/attachments/20040505/6c996e8c/dbus_message_iter_get_args_valist_fix.bin

More information about the dbus mailing list