patch review comments

Kristian Høgsberg krh at
Mon May 17 16:35:57 PDT 2004

Havoc Pennington wrote:
> Hi,
> Various patches here, thanks everyone. I'm pretty sure I didn't get all
> the outstanding stuff, maybe resend or file in bugzilla.
> Havoc
> Kristian patch to the auth stuff
> ===
> This looks pretty reasonable, I think factoring out the send_* functions
> is a nice code cleanup as are the other changes. 
> The split_string() function should have a linefeed before the function
> name, and is generally yucky string stuff but OK in test code. Should be
> sure it only builds with tests enabled.

It's yucky, true, but it's in dbus-auth-script.c which is test only.

> I didn't see anything else wrong here.

Good to hear, it's committed.


More information about the dbus mailing list