[patch] the most horrible patch ever

Havoc Pennington hp at redhat.com
Thu Oct 21 14:04:32 PDT 2004


On Tue, 2004-10-19 at 00:14 -0400, Colin Walters wrote:
> +
> +      if (_dbus_transport_get_is_authenticated (transport) &&
> +         _dbus_transport_get_is_connected (transport))
> +       if (!_dbus_transport_recover_post_auth_data (transport))
> +         return FALSE;

Maybe we could put this in do_reading() and have it be:
 if (!transport->unused_bytes_recovered)
   if (!_dbus_transport_recover_post_auth_data (transport))
     return FALSE;

Slightly better? not sure.

An alternative is to do this in handle_watch() and do_iteration() in
dbus-transport.c to avoid exporting this to the backends. I guess I
might lean that way a bit, if it's sufficient to solve the problem,
since it maintains the encapsulation.


More information about the dbus mailing list