[patch] fix selinux OOM and memory leak

David Zeuthen david at fubar.dk
Wed Apr 13 07:30:03 PDT 2005


On Wed, 2005-04-13 at 10:17 -0400, Havoc Pennington wrote:
> Meant to send that to the list
> 
> On Wed, 2005-04-13 at 10:16 -0400, Havoc Pennington wrote:
> > /me mumbles something about how we should have test coverage on the
> > selinux stuff since the dispatch.c test framework would have caught this
> > bug and writing the test was probably faster than debugging this
> > 

Are you sure this is so easy? I guess you would need to stub out
non-trivial libselinux functionality; haven't looked too much into it
though.

> > Patch looks OK to me but it would sure be more reliable to test than to
> > inspect ;-)

OK, I've committed the patch that I posted here. We might want to tweak
a bit more with the fixes suggested by Colin (once he responds to my
other mail) but the main fixes are in now.

Cheers,
David




More information about the dbus mailing list