Check for Gtk version 2.6.0

[Colin Walters]

On Tue, 2005-02-15 at 13:48 +0530, Inguva Rajasekhar wrote:

>--- configure.in.org    2005-02-15 13:10:38.355774915 +0530
>+++ configure.in        2005-02-15 13:25:10.187826420 +0530
>@@ -841,12 +841,12 @@ if test x$have_glib = xno ; then
>     AC_MSG_WARN([Can't use GTK+ since GLib not enabled])
>     have_gtk=no
> else
>-    PKG_CHECK_MODULES(DBUS_GTK, gtk+-2.0, have_gtk=yes, have_gtk=no)
>+    PKG_CHECK_MODULES(DBUS_GTK, gtk+-2.0 >= 2.6.0, have_gtk=yes, have_gtk=no)
>     PKG_CHECK_MODULES(DBUS_GTK_THREADS, gtk+-2.0 gthread-2.0, have_gtk_threads=yes, have_gtk_threads=no)
> fi

It would probably be nicer to just not build the viewer if we don't have
GTK 2.6.  To do that, you'd do the test first for >= 2.6.0, and set a
variable like have_gtk26.  Then create an Automake conditional based on
that, and make the build in tools/Makefile.am use it.

> if test x$have_gtk = xno ; then
>-    AC_MSG_WARN([GTK+ development libraries not found])
>+    AC_MSG_ERROR([GTK+ development libraries not found])
> fi

This looks wrong to me, because it makes GTK+ always required, and:
 
> if test x$enable_gtk = xyes; then

Right here we check if the user really wanted GTK+.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/dbus/attachments/20050215/554ab401/attachment.pgp