doing a release, future plans
Havoc Pennington
hp@redhat.com
Tue Jan 11 14:39:14 PST 2005
On Tue, 2005-01-11 at 17:28 -0500, Joe Shaw wrote:
> Ok, the DESTDIR fix is in. Do you mean the ListActivatableServices
> patch? It hasn't been reviewed yet, and I don't know the activation
> stuff well enough to give it my ok.
IIRC it looked fine (the latest version of it), assuming make check
still works and there are tests for the new method.
> What's the < vs. > bug in the tests? I couldn't find anything about it
> on the list or bugzilla.
--- dbus-sysdeps.c 3 Jan 2005 07:16:12 -0000 1.84
+++ dbus-sysdeps.c 11 Jan 2005 22:35:04 -0000
@@ -3528,9 +3528,9 @@ _dbus_sysdeps_test (void)
_dbus_warn ("Failed to parse double");
exit (1);
}
- if (ABS (0xff - val) < 1e-6)
+ if (ABS (0xff - val) > 1e-6)
{
- _dbus_warn ("Failed to parse 0xff correctly, got: %f", val);
+ _dbus_warn ("Failed to parse 0xff correctly, got: %f\n", val);
exit (1);
}
I just checked it in, I didn't realize I had no other changes to that
file.
> Yeah, which is why I am trying to beat the clock and get a release
> out. ;) It'll probably take a little while for things to stablize,
> which I'm not really worried about, but I'd prefer to have a tarball
> that we can package and point beagle users to instead of having them
> check out a certain date from CVS. :)
Makes sense. I'm hoping that if "make check" still works when I commit,
things can't be hosed too badly.
> > If you want to make a new release before this mess lands then that's
> > fine with me. If not, I definitely want to make a release as soon as the
> > dust settles.
>
> Ok, I'll go for it. A release afterward makes sense.
There are release instructions in HACKING, though I think we changed
wiki software on fd.org so there may be a speedbump there.
Havoc
More information about the dbus
mailing list