[guus@debian.org: Bug#290306: dbus-1-dev: silly typedefs]

[Havoc Pennington]

On Thu, 2005-01-13 at 22:32 +0100, Guus Sliepen wrote:
> 
> Sure, but as you can see, the current typedefs could well be the cause
> of a security hole on another architecture. The blind wrapping done in
> dbus-types.h is detrimental to security.
> 

D-BUS will fail make check in quite a few places if the 32 or 64 bit
types are defined incorrectly (or if sizeof(char) != 1) because those
sizes are heavily relied upon. Even if you don't run make check, then
dbus simply won't work at all with these types defined incorrectly, so
any sort of testing will discover the issue.

I don't know if the 16-bit types are ever used, but we could easily 
add assert (sizeof(dbus_uint16_t) == 2) to the code or just remove the
16-bit typedefs.

It just isn't a problem in practice. I think glib and Qt (and a lot of
other libraries, for that matter) have shown that.

Havoc