recursive types work

[Joe Shaw]

On Mon, 2005-01-24 at 22:10, Havoc Pennington wrote:
> Can't you do dbus_message_iter_get_current_type(&array_iter) !=
> DBUS_TYPE_INVALID?

Sure.  That's a private function right now, though.  I can export it.

> Probably init() and recurse() should be consistent on whether they
> return this automatically.
> Oddly enough get_current_type() is one of the highest things in the
> performance profile right now, so I'm wondering if we should drop the
> return value from init(). Another reason to do that may be that it's a
> bit confusing whether the return value is for OOM or "nothing to iterate
> over"

It really doesn't matter much to me either way.

> I dunno, I haven't done a real performance analysis yet  - (k)cachegrind
> is all busted on my system for some reason, and sysprof keeps disabling
> my keyboard someway and that gets old.

Pesky interrupts. :)

It's not urgent, so long as you don't pass an empty array in as an
argument in the mono bindings... I can send a patch for one of both
items.

Thanks,
Joe