Please run `make check` before checking in code

Colin Walters walters at verbum.org
Fri Jul 1 23:06:59 PDT 2005


On Sat, 2005-07-02 at 01:44 -0400, John (J5) Palmieri wrote:
> I get this from a fresh checkout:
> 
> dbus-glib-test: running mainloop integration tests
> 
> ** ERROR **: file dbus-gmain.c: line 768 (_dbus_gmain_test): assertion
> failed: (gtype == G_TYPE_OBJECT)

Fixed.

> It makes it harder to debug when I can't be sure if make check is
> failing because of a patch I just added or a patch added awhile back.

If I've only changed glib/ I tend to just run 'make check' in test/glib
since that test suite is very extensive and covers nearly everything.
There are just a few minor unit tests in glib/; but from now on I'll do
(cd glib && make check) && (cd test/glib && make check)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/dbus/attachments/20050702/e6892352/attachment.pgp


More information about the dbus mailing list