[patch] remove DBusGPendingCall
walters at verbum.org
Wed Jul 6 10:58:22 PDT 2005
On Wed, 2005-07-06 at 13:42 -0400, Ray Strode wrote:
> > I do return an opaque pointer; the client code never knows it doesn't
> > point to allocated memory. This way there's no need to define a
> > structure, allocate it, etc. Converting the DBusGProxyCall * pointer
> > into a guint will be a very cheap operation, just a few processor cycles
> > at most I imagine if any. If we get to that level of optimization I
> > will be very happy :)
> You're using the index as a key into a hash table to retrieve a
> pointer, yea? I guess my point is, why have the hash table at all?
> Why not just return the pointer in the first place? What's the
> advantage of the extra layer of indirection?
Well...we could do that but potentially lose some safety if someone
passes an already-cancelled pending call or one for a different proxy
Personally, I just want to get the API change in as soon as possible,
and leave optimizations/minor code cleanup until the major bugs/missing
features are fixed/implemented.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/dbus/attachments/20050706/575b9bba/attachment.pgp
More information about the dbus