Warning while compiling dbus 0.34

[John (J5) Palmieri]

On Mon, 2005-07-11 at 20:31 +0200, Ikke wrote:
> On Mon, 2005-07-11 at 14:20 -0400, Colin Walters wrote:
> > On Mon, 2005-07-11 at 11:40 -0400, John (J5) Palmieri wrote:
> > > That is just the Pyrex python module generator being stupid.  I brought
> > > up these issues with the upstream maintainers and their response was,
> > > "it would complicate the code too much to fix the issues".  The lvalue
> > > warnings however have been fixed (they used to be errors or at least
> > > error out on fedora's gcc).  You can grab the patch from the fedora RPM
> > > of Pyrex if you want.  It should be showing up when they do the next
> > > release of Pyrex upstream hopefully.   
> > 
> > As a temporary workaround it might be nice at some point if we changed
> > CFLAGS in configure.in to be the core CFLAGS (e.g. -DDBUS_COMPILATION)
> > and another WARN_CFLAGS or something.  Then for the Python bindings we
> > drop WARN_CFLAGS.
> Just a thought: wouldnt it be better to do it the other way around? Like
> that you dont have to add WARN_CFLAGS to every non-python Makefile.am,
> only need to change the python ones:
> In configure.in:
> PYTHON_CFLAGS="-all -flags -used -by -both -python -and -common -cflags"
> CFLAGS="-Wall -Werror -pedantic -ansi ${PYTHON_CFLAGS}"
> 
> Then in all Python Makefile.am's:
> CFLAGS=$(PYTHON_CFLAGS)
> 
> I did not test this, just guessing it should give the same result with
> less work.
> 
> Regards,
> 
> Ikke
> http://www.eikke.com

This would work since the last switch is taken.  So we could do
-Wnoerror (or is it no-error) for example.  I'll have to check to make
sure I want to do this.  In some cases the warnings are actually legit.
The warning spam is annoying but not really much of a problem. 

-- 
John (J5) Palmieri <johnp at redhat.com>