[patch] connection_open/connection_disconnect lacks symmetry (TODO Item)

[David Zeuthen]

On Mon, 2005-06-06 at 14:39 -0400, Havoc Pennington wrote:
> On Mon, 2005-06-06 at 14:08 -0400, David Zeuthen wrote:
> > 
> > I know D-BUS isn't at 1.0 but can we *please* be a bit more careful in
> > the future? It's just stupid to break ABI for something as trivial as
> > this; IMO you should have waited until there were real ABI breakage.
> > Which I'm sure we will enjoy at some point (and then go to 0.40.x,
> > 0.50.x and so on).
> 
> It's fine with me to hold off the patch until there are other changes,
> or revert it until then.

I'm going to commit something like the attached patch instead of
reverting John's commit.

The thing is that many projects are using D-BUS; specifically we're
shipping D-BUS 0.33 in Fedora Core 4 so if e.g. 0.34 is going to break
ABI all projects using D-BUS needs to either branch (like hal 0.4.x is
using D-BUS 0.22 and hal 0.5.x is targeting HEAD) or do funky stuff
(like NetworkManager is capable of supporting both 0.23.x and HEAD).

Perhaps all the work going for 1.0 should be moved to a branch the
moment we need to break ABI? I'm mostly concerned about e.g. jhbuild and
the fact that more and more GNOME stuff for 2.12 is starting to use
D-BUS in non-trivial ways.

Cheers,
David



> 
> Havoc
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dbus-add-back-disconnect.patch
Type: text/x-patch
Size: 3189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/dbus/attachments/20050606/541953e8/dbus-add-back-disconnect.bin