[patch] don't break ABI in upcoming 0.34 release

John (J5) Palmieri johnp at redhat.com
Tue Jun 14 20:35:40 PDT 2005


Ok with me but I think it was Havoc who bumped the soname.

On Tue, 2005-06-14 at 22:00 -0400, David Zeuthen wrote:
> Hi,
> 
> Even though we break the protocol somewhere after 0.33 we don't actually
> change the libdbus interface so bumping the soname is not necessary.
> Packagers should be advised to not restart the system message bus in
> e.g. %post though (but this already breaks a lot of stuff). I've tested
> HEAD with this patch and at least HAL and NetworkManager is still as
> happy as with 0.33. Without the patch recompiles are required. Hence the
> patch.
> 
> The commit message referenced in the patch is this one
> 
> >         * configure.in (LT_*): add notes on how the libtool versioning
> >         works to save thinking. Increment soname to indicate protocol
> >         breakage (though really the library interface hasn't changed I
> >         guess)
> 
> If we don't commit this we ought to call the next release 0.40. Yes,
> this will probably break it for some jhbuild users building GNOME HEAD
> but I'd rather do that than having to have a third branch of D-BUS
> (meaning we would have 0.23.x, 0.33.x and HEAD).
> 
> OK to commit?
> 
>     David
> 
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/dbus/dbus/ChangeLog,v
> retrieving revision 1.790
> diff -u -p -r1.790 ChangeLog
> --- ChangeLog   14 Jun 2005 15:55:10 -0000      1.790
> +++ ChangeLog   15 Jun 2005 01:52:27 -0000
> @@ -1,3 +1,10 @@
> +2005-06-14  David Zeuthen  <davidz at redhat.com>
> +
> +       * configure.in (LT_CURRENT): Revert back to 1 as the library
> +       hasn't changed and we've certainly not committed to protocol
> +       stability yet.  All this does is to break ABI. See commit note
> +       from hp at redhat.com 2005-05-05 for details.
> +
>  2005-06-14  Colin Walters  <walters at verbum.org>
> 
>         * glib/dbus-binding-tool-glib.c:
> Index: configure.in
> ===================================================================
> RCS file: /cvs/dbus/dbus/configure.in,v
> retrieving revision 1.116
> diff -u -p -r1.116 configure.in
> --- configure.in        18 May 2005 15:44:50 -0000      1.116
> +++ configure.in        15 Jun 2005 01:52:28 -0000
> @@ -23,7 +23,7 @@ AM_MAINTAINER_MODE
>  #
> 
>  ## increment if the interface has additions, changes, removals.
> -LT_CURRENT=2
> +LT_CURRENT=1
> 
>  ## increment any time the source changes; set to
>  ##  0 if you increment CURRENT
> 
> 
> 
> 
-- 
John (J5) Palmieri <johnp at redhat.com>



More information about the dbus mailing list