[patch] fix automatic reload of configuration files

David Zeuthen david at fubar.dk
Wed Nov 2 08:11:54 PST 2005


On Wed, 2005-11-02 at 15:36 +0100, Timo Hoenig wrote:
> Currently, reloading configuration files does only work when running
> dbus-daemon with --nodaemon.  If we are running as daemon we're hitting
> a dnotify bug once we fork the process.
> 
> We're initializing the dnotify fds before calling fork().  Once the
> child process forked it does still have the fds (and they still show up
> in /proc/`pidof dbus-daemon`/fd/) but we're not getting SIGIO as changes
> are made to the configuration files.
> 
> The attached patch moves the initialization of the dnotify fds to
> process_config_postinit().  This is safe for all current code paths and
> solves the dnotify disfunction.  If we're running dbus-daemon as daemon
> the fds for dnotify are now being initialized after fork() for the child
> process.

Looks good to me, just glancing at it this morning.

Thanks,
David




More information about the dbus mailing list