[PATCH] GLib binding properties (was Properties again)

[Carlos Garcia Campos]

El mié, 09-11-2005 a las 18:17 +0100, Carlos Garcia Campos escribió:
> El mar, 01-11-2005 a las 13:04 -0500, John (J5) Palmieri escribió:
> > It looks good to me but I don't hack much on the GLib bindings.  Rob
> > Taylor, this looks like it might be of interest to you because of the
> > signature stuff.  Right now the patch gets the signature from the type
> > being sent back but this doesn't work for empty containers so...
> 
> I've realized it only works for basic types because I was using
> _dbus_gtype_to_signature. Doing _dbus_gvalue_to_signature "public" and
> using it instead solves the problem. I've attached an updated path. 
> 
> > On another note when sending a patch for review it is good to indicate
> > it in the subject line, also being descriptive and pointing out what
> > part of the code it touches (i.e. the GLib bindings in this case) is
> > good form because it allows people to triage and quickly find the mails
> > that are of interest to them.
> 
> Ok, sorry, I'll do it the next time. 
> 
> > Thanks for the patch.
> > 
> > On Tue, 2005-11-01 at 16:17 +0100, Carlos Garcia Campos wrote:
> > > Hi,
> > > 
> > > I said properties work perfectly with the glib bindings, but I only had
> > > used setters. The Get method doesn't work, because of a bug. The problem
> > > is that it tries to append a basic type instead of a GValue in the
> > > method return message and in addition it is appended to the wrong
> > > message. 
> > > The attached path fixes it. 
> > > 

Any chance to have this in for the next release?

Greetings, 
-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Carlos Garcia Campos a.k.a. KaL
   elkalmail at yahoo.es
   carlosgc at gnome.org
   http://carlosgc.linups.org
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=             
PGP key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x523E6462
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada
	digitalmente
Url : http://lists.freedesktop.org/archives/dbus/attachments/20051122/9468ed72/attachment.pgp