[PATCH] GLib: Get the sender from the GMethodInvocation and other fixes

John (J5) Palmieri johnp at redhat.com
Tue Nov 22 08:28:19 PST 2005


On Tue, 2005-11-22 at 01:29 +0000, Robert McQueen wrote:

> Looks fine to me, although a possible caveat: this returns a const
> pointer to presumably memory from within the header cache, which might
> be freed once the incoming message is unreferenced. Its worth
> considering and documenting what the valid scope of the returned pointer
> is expected to be, and either clarify it or consider if this function
> should return eg a gchar * which the caller is responsible for freeing.

You are right here.  I'll apply the patch with a strdup'ed return.

-- 
John (J5) Palmieri <johnp at redhat.com>



More information about the dbus mailing list