[PATCH] NoReply annotation in GLib bindings
John (J5) Palmieri
johnp at redhat.com
Mon Oct 24 15:03:08 PDT 2005
On Mon, 2005-10-24 at 22:15 +0100, Ross Burton wrote:
> On Mon, 2005-10-24 at 14:44 -0400, John (J5) Palmieri wrote:
> > Looks good to me. Perhaps we should standardize this to
> > org.freedesktop.DBus.Method.NoReply?
>
> That would be the only one defined without GLib in the name. Should we
> review all of the names and categorise them into general vs
> GLib-specific?
>
>
> "org.freedesktop.DBus.GLib.CSymbol"
> GLib-specific?
I would think so since this is mainly for the binding tool. It could be
changed to org.freedesktop.DBus.C.Symbol but unless we have another tool
using it I would say leave it as is.
> "org.freedesktop.DBus.GLib.Async"
> Glib-specific.
>
> "org.freedesktop.DBus.GLib.Const"
> Not sure what this does, GLib-specific I think.
>
> "org.freedesktop.DBus.GLib.ReturnVal"
> I can never remember what this does, glib-specific I think though.
Those all look GLib specific.
> "org.freedesktop.DBus.GLib.NoReply"
> General I guess.
>
> Should I commit NoReply as .Method. or .GLib.?
I would say .Method. as I could add this to the Python bindings also.
This would require a spec change if you did commit it so make sure you
do that too.
--
John (J5) Palmieri <johnp at redhat.com>
More information about the dbus
mailing list