[patch] do not segfault when D-Bus connection is reused
Havoc Pennington
hp at redhat.com
Thu Aug 24 11:39:41 PDT 2006
John (J5) Palmieri wrote:
> On Thu, 2006-08-24 at 11:22 -0400, Havoc Pennington wrote:
>> Also just noticed that check_connection_and_unref has some problems; it
>> doesn't do proper thread locking, and it doesn't handle DBUS_BUS_STARTER
>
> DBUS_STARTER doesn't get handled because it is mapped to system or
> session. From my original reading of the code handling DBUS_STARTER
> would cause a double unref.
>
Hmm, needs a comment at least. It's probably cleaner to just ref
DBUS_STARTER again when we put it in the array of connections, so this
function can just iterate over the array of connections instead of
special-casing each array member.
Havoc
More information about the dbus
mailing list