[PATCH] Fix deadlock in an error path

[Doug Goldstein]

Havoc Pennington wrote:
> 
> 
> John (J5) Palmieri wrote:
> 
>>
>> which indeed checks to see if there is a lock so
>> _dbus_bus_notify_shared_connection_disconnected_unlocked needs to assume
>> there is a lock.
>>
> 
> Those are two different locks.
> 

Maybe then a rename is in order to make it a bit more clear so we don't
run into a similar situation in the future? Or worse someone doesn't
commit a code "fix" making a similar mistake as well.

Because I certainly looked at it and the Redhat bug as was about to
patch the Gentoo release because John's conclusions seemed correct to me
as well.



-- 
Doug Goldstein <cardoe at gentoo.org>
http://dev.gentoo.org/~cardoe/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.freedesktop.org/archives/dbus/attachments/20061204/5ff1d992/signature.pgp