[PATCH] Privatize the DBusPendingCall struct

[John (J5) Palmieri]

Here is a patch which makes DBusPendingCall and opaque object.  A couple
of things I noticed while doing this:

* Setting the connection is not needed so we can get rid of
_dbus_pending_call_set_connection.  This is because it is set by
_dbus_pending_call_new and the only time the connection is otherwise
being set is in _dbus_connection_attach_pending_call_unlocked which is
called a few lines after _dbus_pending_call_new is called in
dbus_connection_send_with_reply.

* The above being true, there is no reason why we need to NULL out the
connection and it can stay for the lifetime of the PendingCall object.
This will alleviate the cause of the cause of the NetworkManager crash.
We may still need to make sure we are holding a ref to the connection
object itself.


-- 
John (J5) Palmieri <johnp at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dbus-privatize-pending-call.patch
Type: text/x-patch
Size: 22582 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/dbus/attachments/20060710/c30c8b8d/dbus-privatize-pending-call.bin