[PATCH] Privatize the DBusPendingCall struct

John (J5) Palmieri johnp at redhat.com
Wed Jul 26 08:31:19 PDT 2006


Patch looks good and I have been running it for a day now.  Nothings 
seems out of the ordinary.  Attached is a modified version sans the 
ChangeLog and TODO patch which applies to CVS head.  I think it is ready 
to be committed.

As for the timeout bug I fixed instead of getting the asserts we get get 
activation errors but I think these are expected.  The error message 
changed but I believe that was your doing to make it more clear.  
Sometimes it is hard to tell what is supposed to fail and how they are 
supposed to fail.


Havoc Pennington wrote:
> Here is what the full fix might look like. I haven't really tested it; 
> if someone could test/debug that would be a good idea. I don't have a 
> lot of time to work on this.
>
> I see a bunch of errors in 'make check' about removing timeouts that 
> weren't added (mixed in with the "out of memory" errors that I believe 
> are expected, but the timeout ones are not).
>
> Don't know if this patch introduces those, but they need fixing in any 
> case.
>
> I added a TODO item for 1.0 which amounts to testing and committing 
> the attached patch (including that error about removing timeouts, that 
> should also be a 1.0 blocker as it surely indicates some real bug)
>
> btw, I think I'm still the only or one of the few people getting dbus 
> bugzilla mail, but I'm not doing anything about any of it, so maybe 
> others want to jump on that cc list...
>
> Havoc
>
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: dbus-0.90-pending-call-add-lock.patch
Type: text/x-patch
Size: 37338 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/dbus/attachments/20060726/4e4dab3d/dbus-0.90-pending-call-add-lock-0001.bin


More information about the dbus mailing list