[PATCH] Allow eavesdropping on method calls

Havoc Pennington hp at redhat.com
Sat Jun 3 21:46:13 PDT 2006


John (J5) Palmieri wrote:
> -  if (type == DBUS_MESSAGE_TYPE_METHOD_CALL)
> +  if (type == DBUS_MESSAGE_TYPE_METHOD_CALL &&
> +        addressed_recipient == proposed_recipient /* not eavesdropping */)
>      {

There's another if() right after this one with "(sender && 
addressed_recipient && ...)"

It would make more sense to me to put the addressed_recipient == 
proposed_recipient test in that subsequent if() block, though it makes 
no real difference.

I don't understand why this fixes eavesdropping, though it looks like a 
correct fix ... can you elaborate a little?

Havoc



More information about the dbus mailing list