Crash in _dbus_connection_block_pending_call

[Timo Hoenig]

Hi,

There is a crash in libdbus-1 once in a while.  It looks very racy as it
only happens sometimes.

Tracking down this issue a little further showed that the fix for block
on pending calls [1] is causing the crashes.  When reverting the patch
everything works fine and NetworkManager (NM) does not crash.

Here's a excerpt of the NM trace [2] when crashing:

41 Jun  8 13:32:49 linux-qo35 NetworkManager: No symbol table info available.
42 Jun  8 13:32:49 linux-qo35 NetworkManager: #4  <signal handler called>
43 Jun  8 13:32:49 linux-qo35 NetworkManager: No symbol table info available.
44 Jun  8 13:32:49 linux-qo35 NetworkManager: #5  0xb7e5e9a7 in _dbus_list_get_first_link () from /usr/lib/libdbus-1.so.2
45 Jun  8 13:32:49 linux-qo35 NetworkManager: No symbol table info available.
46 Jun  8 13:32:49 linux-qo35 NetworkManager: #6  0xb7e48e0a in _dbus_connection_block_pending_call () from /usr/lib/libdbus-1.so.2
47 Jun  8 13:32:49 linux-qo35 NetworkManager: No symbol table info available.
48 Jun  8 13:32:49 linux-qo35 NetworkManager: #7  0xb7e55f5d in dbus_pending_call_block () from /usr/lib/libdbus-1.so.2
49 Jun  8 13:32:49 linux-qo35 NetworkManager: No symbol table info available.
50 Jun  8 13:32:49 linux-qo35 NetworkManager: #8  0xb7e49289 in dbus_connection_send_with_reply_and_block () from /usr/lib/libdbus-1.so.2
51 Jun  8 13:32:49 linux-qo35 NetworkManager: No symbol table info available.
52 Jun  8 13:32:49 linux-qo35 NetworkManager: #9  0x0807d16a in nm_dhcp_manager_get_state_for_device ()
53 Jun  8 13:32:49 linux-qo35 NetworkManager: No symbol table info available.

Any ideas?

Thanks,

   Timo

[1] Fix for block on poll issue
    cvs diff -u -r 1.115 -r 1.116 dbus/dbus-connection.c

[2] NM log when crashing
    http://nouse.net/misc/nm-trace