[PATCH] block on poll fix with regression test
Havoc Pennington
hp at redhat.com
Thu Mar 2 11:44:34 PST 2006
On Thu, 2006-03-02 at 14:19 -0500, John (J5) Palmieri wrote:
> Here is the fix to the block on poll issue. It was pretty trivial once
> pointed in the right direction. The test case was bolted on to the
> name-test because I didn't want to duplicate the setup code. We should
> just rename the name-test directory to c_test_suite or something like
> that. The test was run against the bug and the fix.
Thanks, two tweaks I'd do:
- name it check_for_reply_and_update_dispatch_unlocked()
(updating dispatch status != dispatch)
- the test case could probably use a comment explaining the bug
we're testing for
Havoc
More information about the dbus
mailing list