[patch] standard_session_servicedirs (was Re: OLPC and .service files in a users home directory)

Havoc Pennington hp at redhat.com
Thu Nov 2 09:45:48 PST 2006



uwesmail2005-lkml at yahoo.de wrote:
>> Don't write a patch ;-) I don't think it's a good change, it makes 
>> things less clear (and slower, though it doesn't matter)
>>
> Huh? Why not? The function has a good name, that alone should explain
> what's going on. And if that function is inlined it would even be
> (after
> optimizing) the same binary.

Just my opinion that you'd have to pause to read the code with this 
change, and you don't have to now.

The element is not going to be renamed - it would be incompatible - so 
abstracting things to support that is not interesting.

Havoc



More information about the dbus mailing list