[PATCH] do not call _dbus_warn_check_failed on checks

Sebastian Dröge slomo at circular-chaos.org
Mon Nov 13 02:43:16 PST 2006

Am Montag, den 13.11.2006, 11:09 +0100 schrieb Timo Hoenig:
> Hi,
> Here we go, we definitely want that for D-Bus 1.0.1.
> All checks in D-Bus are currently fatal.
> Checks always lead to _dbus_abort as _dbus_return_if_fail and
> _dbus_return_val_if_fail are calling _dbus_warn_check_failed.
> This was introduced after the addition of _dbus_warn_check_failed [1].

I had a discussion with John Palmieri on IRC about this some hours
before 1.0 release and if I didn't misunderstand him completely this is
intended behaviour.

Below are the relevant parts of the explanation why abort() is called:
> Nov 10 00:35:01 <J5> Its fatal because it puts the app in an unknown
> state
> Nov 10 00:35:44 <J5> there are similar X warnings when the client uses
> the API the wrong way


PS: AFAIK at least hal and avahi seem to be fixed to not break with this
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
Url : http://lists.freedesktop.org/archives/dbus/attachments/20061113/63a10daf/attachment.pgp

More information about the dbus mailing list