[PATCH] do not call _dbus_warn_check_failed on checks

John (J5) Palmieri johnp at redhat.com
Mon Nov 13 09:57:45 PST 2006


On Mon, 2006-11-13 at 15:45 +0100, Timo Hoenig wrote:
> Hi Sebastian,
> 
> On Mon, 2006-11-13 at 11:43 +0100, Sebastian Dröge wrote:
> 
> > I had a discussion with John Palmieri on IRC about this some hours
> > before 1.0 release and if I didn't misunderstand him completely this is
> > intended behaviour.
> 
> Interesting.  I would have expected to see such a grave change in
> behavior being brought up on-list.
> 
> So basically we're not having a bunch of checks which are not checks but
> assertions (as long as DBUS_FATAL_WARNINGS is not explicitly set to
> '0').
> 
> Havoc, as you own the commit I am questioning, could you please comment?

There is disable-checks which disables checks on public API and
disable-asserts which disables checks on internal bus API.
disable-asserts should be turned off but disable checks should not
because they indicate an application is using the API incorrectly.
 
-- 
John (J5) Palmieri <johnp at redhat.com>



More information about the dbus mailing list