[PATCH] *BSD patches plus dbus-launch fix for regression tests
John (J5) Palmieri
johnp at redhat.com
Wed Oct 25 16:53:14 PDT 2006
On Tue, 2006-10-24 at 20:59 -0400, Havoc Pennington wrote:
> The dbus-launch change is only partly DBUS_BUILD_TESTS conditionalized.
> I think a less intrusive patch would use an env variable, then you can
> skip all the arg parsing etc. - in fact there may already be some
> relevant env variable like the build dir set in a test context? What if
> you just export the DBUS_TOP_BUILDDIR or something if isn't, from the sh
> script calling dbus-launch?
Attached is a fixed up patch that just has config.in define the binaries
> The HAVE_CMSGCRED change isn't everything that I meant; what I was
> suggesting is that we add a HAVE_LOCAL_CREDS, and adding a configure
> check to define that. And do configure in such a way that only one of
> the two will ever be defined. The patch you have looks good fixing the
> existing code, but the configure change would keep us from doing it
> wrong in the future.
I gave up on this. A real *BSD hacker needs to look at this since there
are numerous code paths. I think some of them are the same but I can't
be sure. We have HAVE_GETPEEREID, SO_PEERCRED, HAVE_GETPEERUCRED,
LOCAL_CREDS and HAVE_CMSGCRED.
John (J5) Palmieri <johnp at redhat.com>
More information about the dbus