[patch] standard_session_servicedirs (was Re: OLPC and .service files in a users home directory)

[John (J5) Palmieri]

On Tue, 2006-10-31 at 17:14 -0500, John (J5) Palmieri wrote:
> On Mon, 2006-10-30 at 21:10 -0500, Havoc Pennington wrote:
> > John (J5) Palmieri wrote:
> > > I went ahead and did the variable substitution method here.  Special
> > > characters need to be escaped so I had to change some of the valid
> > > config files to escape their & entities.  This is a half of a patch.
> > > I still need to deal with multiple directories in an atomic fashion.  If
> > > there is a consensus that xdg_relative="true" attribute is the better
> > > way to go then I can change the patch accordingly.  The only issue I
> > > have with xdg_relative="true" is that the system bus would be looking
> > > in /.local/dbus-1/service for no reason once we have activation there.
> > > I have an issue with sensitive services running through useless code
> > > even if it is just paranoia.
> > > 
> > > 
> > 
> > I think Thiago is right that there's probably no point allowing a 
> > relative subdir, so just
> > 
> > <standard_session_bus_servicedirs/>
> > 
> > I think would be a good approach. In terms of implementation, it should 
> > simply "expand" as if a list of standard <servicedir> had been manually 
> > indicated.
> > 
> > I prefer this to <servicedir xdg=true/> because an attribute shouldn't 
> > effectively change an element into a different element.
> > 
> > I would name it <standard_session_bus_servicedirs/> since for example 
> > the xdg spec is not relevant on Windows, but there may still be some 
> > standard session bus service dirs.
> 
> Ask and you shall receive, complete with a test case.  This patch will
> try to pick up the XDG_DATA_HOME and XDG_DATA_DIRS variables and tack
> on /dbus-1/services to those directories.  If not found it will use the
> standards from XDG.  It even handles multiple directories separated by
> colons (in XDG_DATA_DIRS only).  All of the xdg code is in
> dbus-sysdeps-unix.c so that the same tag can be used under windows to
> provide different standard directories there.
> 
> I want to add this patch and do a final release before 1.0 barring any
> major bugs that come up.  I figure we do this release, fix up the docs
> and then do a final 1.0 release if all goes well.

Hmm, it seems I edited session.conf in test/data instead of in bus/.
Here is the patch for that too.
-- 
John (J5) Palmieri <johnp at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dbus-session-conf.patch
Type: text/x-patch
Size: 557 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/dbus/attachments/20061031/0422719f/dbus-session-conf.bin