[patch] Fix refcounting and locking in dbus-connection

John (J5) Palmieri johnp at redhat.com
Tue Sep 5 14:11:19 PDT 2006

I removed it from the files in bus/ and make check still passed.  We
still need it for dbus-connection.c and dbus-bus.c but I could rename it
to _dbus_connection_close_shared or _dbus_connection_close_no_check.

On Tue, 2006-09-05 at 16:38 -0400, Havoc Pennington wrote:
> Hi,
> I don't think close_internal is right - it doesn't make sense to call 
> close() on a shared bus outside of its owner (libdbus), for either 
> internal or external callers. Also, the bus daemon ideally uses only 
> public API for the actual bus stuff, the internal API it uses is all the 
> "utility" stuff.
> I think the bus daemon should probably be using connection_open_private 
> - well, for that matter does it open connections at all? I thought it 
> only received connections. So they should not be shared, right?
> The other changes looked OK on first glance though I did not review in 
> detail, it would be good if someone else did.
> Havoc

John (J5) Palmieri <johnp at redhat.com>

More information about the dbus mailing list