[patch] Move method into TEST macros and check for verbose in
John (J5) Palmieri
johnp at redhat.com
Fri Sep 8 13:47:25 PDT 2006
On Fri, 2006-09-08 at 16:21 -0400, Havoc Pennington wrote:
> John (J5) Palmieri wrote:
> > - if (!verbose)
> > + if (!_dbus_is_verbose_real())
> Maybe leave this accessing the variable directly, just so this function
> is as fast as possible with verbose disabled? (this is dbus_verbose_real
That is there because it calls _dbus_verbose_init() (I should inline
that). I could go back to calling _dbus_verbose_init and then checking
verbose for speed.
> Patch looks fine.
More information about the dbus