[PATCH 16/17] dbus/connection.py: comments
John (J5) Palmieri
johnp at redhat.com
Mon Apr 30 15:09:59 PDT 2007
Comments are always good.
On Mon, 2007-04-30 at 13:33 +0100, Simon McVittie wrote:
> diff --git a/dbus/connection.py b/dbus/connection.py
> index 0ba64ab..4dc4ead 100644
> --- a/dbus/connection.py
> +++ b/dbus/connection.py
> @@ -73,7 +73,11 @@ class SignalMatch(object):
> self._member = member
> self._path = object_path
> self._handler = handler
> +
> + # if the connection is actually a bus, it's responsible for changing
> + # this
> self.sender_unique = sender
> +
> self._utf8_strings = utf8_strings
> self._byte_arrays = byte_arrays
> self._sender_keyword = sender_keyword
> @@ -343,6 +347,8 @@ class Connection(_Connection):
> {})
> by_member = by_interface.setdefault(dbus_interface, {})
> matches = by_member.setdefault(signal_name, [])
> +
> + # make sure nobody is currently manipulating the list
> self._signals_lock.acquire()
> try:
> matches.append(match)
> _______________________________________________
> dbus mailing list
> dbus at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dbus
More information about the dbus
mailing list