[patch] small leak

Brian Mattern brian.mattern at gmail.com
Sat Feb 10 23:17:28 PST 2007


Sorry, its too late. Ignore this crack.
However, valgrind is complaining about something here.
I'll look at it more after I get some sleep. :)

Brian

On Sun, Feb 11, 2007 at 01:09:01AM -0600, Brian Mattern wrote:
> dbus_message_unref() won't free a DBusError... :)
> 
> Brian

> Index: dbus-pending-call.c
> ===================================================================
> RCS file: /cvs/dbus/dbus/dbus/dbus-pending-call.c,v
> retrieving revision 1.24
> diff -u -r1.24 dbus-pending-call.c
> --- dbus-pending-call.c	21 Oct 2006 23:09:18 -0000	1.24
> +++ dbus-pending-call.c	11 Feb 2007 07:04:31 -0000
> @@ -399,7 +399,7 @@
>        
>    if (pending->timeout_link)
>      {
> -      dbus_message_unref ((DBusMessage *)pending->timeout_link->data);
> +      dbus_error_free ((DBusMessage *)pending->timeout_link->data);
>        _dbus_list_free_link (pending->timeout_link);
>        pending->timeout_link = NULL;
>      }

> _______________________________________________
> dbus mailing list
> dbus at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dbus




More information about the dbus mailing list