reverted commits

Havoc Pennington hp at
Thu Jul 12 15:42:12 PDT 2007


Ralf Habacker wrote:
>> Are you serious? 
> yes

The test case is:

parse_double('0xff') == 255

If you "fix" that by writing:

 if (nptr && strlen(nptr) == 4 && nptr[0] == '0' && nptr[1] == 'x' &&
     nptr[2] == 'f' && nptr[3] == 'f')
        if (endptr)
          *endptr = nptr+4;
        return 0.0;

It's both a ridiculous patch you haven't thought about for longer than 
half a second, AND you did not even try 'make check' after coding it, 
AND I had already suggested two non-wrong ways to do it which you 
apparently didn't read.

In other words, you are spending zero time yourself, and hoping everyone 
else will do the work for you.

In this case I just did, I fixed it for you in CVS. Don't expect it to 


More information about the dbus mailing list