[patch] DBUS System Activation II

[Richard Hughes]

On Tue, 2007-06-19 at 10:51 -0400, Havoc Pennington wrote:
> Hi,
> 
> Richard Hughes wrote:
> >> Sounds like a reasonable approach for now, better than nothing. Rather 
> >> than adding activation-specific stuff to 
> >> _dbus_babysitter_set_child_exit_error() I would probably add 
> >> _dbus_babysitter_get_child_exit_status() and then process the status in 
> >> activation.c. (Or something like that.)
> > 
> > Hmm, I'm not sure I follow. You want the spawn code to call into the
> > activation code?
> 
> The point is that dbus-spawn.c is not a file that has anything to do 
> with activation. It shouldn't call into it or refer to it. dbus-spawn.c 
> should provide an API to get the exit code of a spawned process. The 
> activation-helper-specific exit codes, however, can be interpreted in 
> activation.c, and the codes header can go in bus/ rather than dbus/

Sure, understood, agreed.

> Don't try to use set_child_exit_error(), add 
> _dbus_babysitter_get_child_exit_status(), in other words.
> 
> > Sure, I've done this in the attached patch. Yell if the error names are
> > wrong, I'm usually pretty bad at choosing names for this sort of
> > thing :-)
> 
> The main thing I'd change is to call it EXIT_CODE rather than RETVAL

Done.

Richard.