reverted commits

Ralf Habacker ralf.habacker at
Thu Jun 21 15:46:52 PDT 2007

Havoc Pennington schrieb:
> Hi,
> I reverted two changes to cross-platform code that were a) wrong until I 
> am convinced otherwise and b) not posted to this list or reviewed in 
> bugzilla, that I can remember.
 >    * dbus/dbus-sysdeps-util.c (_dbus_sysdeps_test): as I have pointed
 >   out before,

where ?
This issue was on the open patch list and was known and discussed 
several times in the dbus list.

My mistake was not to use DBUS_WIN_FIXME, sorry for that.


    * dbus/dbus-watch.c (dbus_watch_get_fd): 1) its behavior should
    not be the same as before, the ABI has never been declared stable
    on Windows and

I have posted a patch to the list in, 
which guarantates the same behavior of dbus_watch_get_fd() on win32 as before. 

You have taken this patch and modified it in a manner that all windows bindings are broken although we have informed you about this issue in
>>/ I would think we can just get rid of this now and pass sockets around 
/>>/ as sockets. Pretty much all the socket-related code is cross-platform.
/>>/ Any reason why not?/

Then we have reverted all our work relating to DBusSocket but the windows builds are still broken because of the changed 
Now we are forced to update all windows bindings which will delay KDE on windows development for several weeks. 
The only thing you tell is that the win32 api isn't declared stable and you request a patch from us, while you have changed.
I hope this is only a misunderstanding which could be cleared. 

This is very pitty because in the next weeks people will travel to the annual meeting of the KDE community 
and they will report about the status of the KDE on windows development 
This is one of the reason why I'm working so hard on dbus cvs. 

Unfortunally we probably have to tell that we cannot show any KDE application on windows because the core component of KDE, 
dbus is broken on windows because the maintainer declares the dbus windows api not stable. 

I hope not. 



More information about the dbus mailing list