dbus-1.2.10 and dbus-1.2.4.2permissive

[Colin Walters]

On Fri, Dec 19, 2008 at 6:46 PM, Michael Biebl <mbiebl at gmail.com> wrote:
> 2008/12/20 Michael Biebl <mbiebl at gmail.com>:
>> 2008/12/19 Colin Walters <walters at verbum.org>:
>>>
>>> Primary stream: http://dbus.freedesktop.org/releases/dbus/dbus-1.2.10.tar.gz
>>>  SHA1: 63088b3443b5fea2df2550fd5827dd514dc31262
>>
>> Fails to compile (for me)
>
> Fix is simply, of course:
>
> Missing #include <syslog.h> in dbus/dbus-sysdeps-util-unix.c

Right...I thought I fixed that at one point, but clearly either the
commit got lost or I'm misremembering.  Regardless, my fault.

However, there is a larger problem here that the compiler warnings
experience in DBus has bitrotted; there are a good collection of
warnings right now a lot of which are noise.  The right thing, I
strongly believe, is to by default use -Werror when in
AM_MAINTAINER_MODE, and manage known warnings.  I've created a patch:
http://bugs.freedesktop.org/show_bug.cgi?id=19196

It's pending review, along with a patch which fixes the syslog warning
and others.

There are also new bugs for the compiler warnings we should fix; if
anyone wants to jump in on e.g.
http://bugs.freedesktop.org/show_bug.cgi?id=19195 that'd be awesome.