[PATCH] dbus-glib patches

Rob Taylor rob.taylor at codethink.co.uk
Mon Mar 17 04:20:38 PDT 2008


David Zeuthen wrote:
> Hey,
> 
> Here's a few simple patches for dbus-glib. 
> 
> The first one is trivial, we just bump the version number.

Looks good..

> The second one is needed if you want to use the generated client glue
> and you have operations that lasts longer than the default timeout.

Hmm, this isn't as useful as it seems, as (iirc) the bus daemon also has 
a 25 sec timeout on method calls. Those kind of operations are better 
structured as a call to start and a signal to stop. Also long operations 
  often need a cancel call as well...

Having said that, I'm happy to have the patch, with added documentation 
to this effect.

> The third patch exports the recently added (to the spec) GetAll() method
> call on the org.fd.DBus.Properties interface.

Looks good.

Thanks,
Rob

> Is this OK to commit? Thanks for considering.
>      David
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> dbus mailing list
> dbus at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dbus



More information about the dbus mailing list