unused functions in dbus-string.c

Havoc Pennington havoc.pennington at gmail.com
Wed Apr 15 14:15:25 PDT 2009


On Wed, Apr 15, 2009 at 4:32 PM, Roberto -MadBob- Guido
<bob4mail at gmail.com> wrote:
> Looking at dbus-string.c I see a number of functions unused in the rest of the
> code, isolated by the DBUS_BUILD_TESTS preprocessor condition and sometime
> checked in unit tests.
> Those are:
> _dbus_string_steal_data_len
> _dbus_string_copy_data_len
> _dbus_string_append_unichar
> _dbus_string_append_4_aligned
> _dbus_string_append_8_aligned
> _dbus_string_get_unichar
> Is there any reason to maintain that code? Perhaps those were used in past,
> but not erased waiting for recycling?

the idea is to keep them working in unit tests, so they're there if
someone needs to use them. If they were deleted, they would bit-rot
and it would be annoying to dig them back out of git.


More information about the dbus mailing list