[HEADS-UP] the road to D-Bus 1.4

Romain Pokrzywka romain.pokrzywka at kdab.com
Wed Aug 11 05:17:28 PDT 2010


On Monday 09 August 2010 09:31:06 Ralf Habacker wrote:
> > I'm not exactly sure why we create a socket at the beginning just to
> > discard it afterwards, it looks like the leftovers  from pre-ipv6 support
> > or a merging mistake, so unless somebody knows a specific reason for it
>
> It looks really that this stuff is a left over from the following commit
> - all changes for dbus-1.2 API (cherry picked from commit 
> 6734a3210a0705e3ab01ee123fac275799877353) from 30.11.2009
>
> As far as i can see can this removed.
>
> > I can rework the patch to 
> > remove that temporary socket for good.
> >   
>
> That cleanup would be nice.

Okay here it comes, together with some error handling fixes and some indentation cleanups.

I've run the tests to make sure I didn't break anything and they still pass (well, except the random lock-up in bus-
tests.exe during SHA-1 connection / message dispatch tests, which is still happening :-(( )

Cheers
Romain

-- 
Romain Pokrzywka | romain.pokrzywka at kdab.com | Certified Qt Software Engineer & Trainer
Klarälvdalens Datakonsult AB, a KDAB Group company
Tel. Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322)
KDAB - Qt Experts - Platform-independent software solutions
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cleanup-removed-unused-code-fixed-Winsock-error-hand.patch
Type: text/x-patch
Size: 9926 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dbus/attachments/20100811/0646ba27/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2396 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dbus/attachments/20100811/0646ba27/attachment-0001.bin>


More information about the dbus mailing list