Assert in dbus-message @576

[Thiago Macieira]

Em Terça-feira, 14 de Dezembro de 2010, às 12:39:43, Olsson, Ola1 escreveu:
> My apologizes, but I can't really see how that can solve the problem since I
> don't agree that Jim got the right answer.
> 
> The assert is in cache_or_finalize() @ 576 but as I wrote, the exact same
> assert is also present in the beginning of the function, however, we have
> no problem passing that one.
> 
> Hence, I don't think this has anything with the atomic instructions as such,
> my concerns is that we don't hold any lock when running _dbus_atomic_dec()
> and keep holding it through the call to cache_or_finalize() in the
> dbus_message_unref() function and there has not been any changes in this
> code between 1.02 and 1.4.
> 
> Do you see my point and concerns? I just want to make sure that we have a
> problem before I fix it.

No, I'm sorry, I really don't see the error. I don't have time to look into it 
right now.

If you can reproduce a buggy behaviour, make sure you report it with a 
testcase and/or description of the issue. Fixes will be welcome to the 1.4 
branch.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/dbus/attachments/20101214/2a50eae6/attachment.pgp>