[PATCH] sysdeps-unix: use MSG_NOSIGNAL when sending creds

Scott James Remnant scott at netsplit.com
Thu Dec 16 03:52:50 PST 2010


As long as all the code was consistent in believing that it was a
#define, the worst case of it not being was that the code would ignore
it.

But I'd probably err on a configure check myself - I just copied the
existing case in sysdeps-unix to match

Scott

On Thu, Dec 16, 2010 at 11:26 AM, Will Thompson
<will.thompson at collabora.co.uk> wrote:
> On 09/12/10 18:41, Scott James Remnant wrote:
>>
>> Since SIGPIPE is no longer touched by default when MSG_NOSIGNAL is
>> available, it's extra-critical that all socket writes actually pass
>> that flag.
>
> This patch got a bit mangled in the mail. I gave up trying to tweak it into
> something Git would understand and applied the same change manually,
> attributed to you:
> <http://cgit.freedesktop.org/dbus/dbus/commit/?id=c5d0998>.
>
> Is it kosher to assume that MSG_NOSIGNAL is a #define (as is done throughout
> the existing code in sysdeps-unix) rather than using HAVE_DECL_MSG_NOSIGNAL
> (as is done in connection)? I guess it could theoretically be an enum
> member?
>
> Cheers,
> --
> Will
>


More information about the dbus mailing list