[PATCH 5/5] activation: implement upstart activation

Lennart Poettering mzqohf at 0pointer.de
Thu Dec 23 14:57:51 PST 2010

On Thu, 23.12.10 22:46, Scott James Remnant (scott at netsplit.com) wrote:

> >> +          retval = bus_dispatch_matches (activation_transaction, NULL, bus_service_get_primary_owners_connection (service),
> >> +                                           message, error);
> >
> >
> > Am I missing something or is there no error path back?
> >
> Correct, an event is always successfully accepted by Upstart.  I
> realised I missed out the (needless) dbus_message_set_no_reply
> (message) - I should put that in for completeness sake.

But what happens if the service fails to start up? If you send no error
message back on failure, then actviation will time-out. You definitely
don't want that, especially since the method invocation timeouts on the
client side are not particularly long.


Lennart Poettering - Red Hat, Inc.

More information about the dbus mailing list