[PATCH] sysdeps-unix: use MSG_NOSIGNAL when sending creds

Lennart Poettering mzqohf at 0pointer.de
Fri Dec 24 02:04:52 PST 2010

On Thu, 16.12.10 14:11, Will Thompson (will.thompson at collabora.co.uk) wrote:

> On 16/12/10 11:52, Scott James Remnant wrote:
> >As long as all the code was consistent in believing that it was a
> >#define, the worst case of it not being was that the code would ignore
> >it.
> >
> >But I'd probably err on a configure check myself - I just copied the
> >existing case in sysdeps-unix to match
> Sure. Does the attached look kosher?

If find this rather unnecessary and just confusing. This complicates the
code for no benefit: MSG_NOSIGNAL is a Linuxism, and on Linux it is a
macro. Hence checking for it via #ifdef directly is a good thing, and
simple and safe.

Plead don't unnecessarily clutter the code with autocnf'ism where they
aren't really necessary!


Lennart Poettering - Red Hat, Inc.

More information about the dbus mailing list