[PATCH 4/5] upstart: add UpstartJob= to service desktop files

Lennart Poettering mzqohf at 0pointer.de
Sat Dec 25 06:36:39 PST 2010


On Fri, 24.12.10 14:53, Will Thompson (will.thompson at collabora.co.uk) wrote:

> >>>I can't say I am a particular fan of parsing booleans like that, where
> >>>every thinkable string is acceptable without error/warning message
> >>>including
> >>>the empty string.
> >>
> >>FWIW,
> >>http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#value-types
> >>documents that the only legal values of type boolean are "true" or "false".
> >>
> >Thanks for the catch; do you think it would be appropriate behaviour
> >for the code to error if neither of these values is given?
> 
> I would personally probably go for issuing a warning of some form
> and then treating it as if "false" was given.

Yes, I agree.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.


More information about the dbus mailing list