[PATCH 2/3] bus: add --address switch

Lennart Poettering mzqohf at 0pointer.de
Wed Jul 7 15:04:59 PDT 2010


On Wed, 07.07.10 16:24, Colin Walters (walters at verbum.org) wrote:

> 
> On Wed, Jun 23, 2010 at 12:10 PM, Lennart Poettering <mzqohf at 0pointer.de> wrote:
> >
> > @@ -473,6 +513,9 @@ main (int argc, char **argv)
> >  #ifdef SIGHUP
> >   _dbus_set_signal_handler (SIGHUP, signal_handler);
> >  #endif
> > +#ifdef SIGTERM
> > +  _dbus_set_signal_handler (SIGTERM, signal_handler);
> > +#endif
> 
> This looks like a bad commit split; we should do clean shutdown on
> SIGTERM, but you didn't change the implementation of signal_handler.

Ah, sorry. That I mismerged when I git rebased my patches. This was not
supposed to be part of the patch. Sorry for the confusion.

> Otherwise the patch looks fine, please commit.

Yay! Thanks for reviewing!

Lennart

-- 
Lennart Poettering - Red Hat, Inc.


More information about the dbus mailing list