[PATCH] Replace libx11 by libxcb

Simon McVittie simon.mcvittie at collabora.co.uk
Tue Jul 27 06:07:05 PDT 2010

Could you attach (a revised version of) this to a freedesktop bug if you
haven't already, please?

I don't speak X11, so I haven't reviewed the C, but here are some fixes for
the autofoo:

On Tue, 27 Jul 2010 at 13:48:20 +0200, Julien Danjou wrote:
> +if test x$enable_x11 = xyes -o x$enable_x11 = xauto ; then

More portable to deficient shells as:

    test x$enable_x11 = xyes || test x$enable_x11 = xauto

> +   if ! $have_xcb -a x$enable_x11 = xyes; then

The second condition isn't checked: it's passed as an argument to true(1) or
false(1). I think you meant:

    if ! $have_xcb && test x$enable_x11 = xyes; then

> +   if ! $have_xcb_aux -a x$enable_x11 = xyes; then

This needs the same change.

> +   if $have_xcb -a $have_xcb_aux; then

Again, the second condition isn't checked. I think you meant:

    if $have_xcb && $have_xcb_aux; then


More information about the dbus mailing list