cygwin dbus port patches

Ralf Habacker ralf.habacker at freenet.de
Thu Jun 17 01:34:05 PDT 2010


Thiago Macieira schrieb:
> Em Segunda-feira 14. Junho 2010, às 04.15.34, Yaakov (Cygwin/X) escreveu:
>   
>> On Sun, 2010-06-13 at 20:38 +0200, Thiago Macieira wrote:
>>     
>>>> There are some flags which GCC allows but have no effect on Cygwin and
>>>> therefore generate warnings as such.  This includes -fPIC and
>>>> -fvisibility*.  Adding the -Werror to cc_supports_flag makes sure that
>>>> the flag is truly supported and necessary.
>>>>         
>>> The problem is that this will cause false-negatives when building code
>>> that is valid.
>>>
>>> I've seen this before, that in maintainer mode there are a couple of
>>> extra warnings enabled like the prototype warning.
>>>       
>> My patch doesn't add -Werror to CFLAGS, it just adds it to
>> cc_supports_flag's testing of the flag itself.  So this will not cause
>> any problems with the code itself.
>>     
>
> It causes false-positives in cc_supports_flag because testing the option causes 
> a warning because of the source code.
>   
Do we have a solution for this ? 

Regards
 Ralf




More information about the dbus mailing list