[Telepathy] dbus-glib GValue to GVariant
Danielle Madeley
danielle.madeley at collabora.co.uk
Thu Jun 24 03:19:40 PDT 2010
On Thu, 2010-06-24 at 11:17 +0100, Will Thompson wrote:
> On 22/06/10 04:16, Danielle Madeley wrote:
> > I've written a proof of concept of this: g_value_to_g_variant (attached)
>
> Looks nice to me. I think it leaks when it recurses, though: you free
> the GPtrArray of children, but don't unref the GVariants. Probably just
> a matter of g_ptr_array_new_with_free_func ((GDestroyNotify)
> g_variant_unref);.
These should be floating references that are eaten up when they're
packed into the containing GVariant. valgrind shows no leak here.
--
Danielle Madeley
Software Developer, Collabora Ltd. Melbourne, Australia
www.collabora.co.uk
More information about the dbus
mailing list