draining the Maemo/Meego patch queue

Colin Walters walters at verbum.org
Wed Mar 17 10:11:57 PDT 2010


2010/3/16 Thiago Macieira <thiago at kde.org>:
>
> Hmm... if we read the file while it's in-flight, shouldn't we get a new
> notification from the filesystem when it's changed again? Won't we read the file
> again at that time?

One thing to keep in mind here is that for processing the .conf
directories, dbus will ignore any file not ending in .conf[1].  So if
the installer/updater mechanism writes out a temporary file
.conf.xxxxx and then does a rename(), things should be fine.

> If that's the case, I'd say just quickly skip any malformed files and don't
> cause any ill-effects -- unless the bus is starting, in which case it should
> complain and refuse to start.

I believe this is what we do currently.  So...my conclusion here is
not to take the Debian patch.

[1] bus/config-parser.c:2192


More information about the dbus mailing list